Skip to content

Add tests for dummy requests creation and removal #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from

Conversation

gmarinho2
Copy link
Collaborator

@gmarinho2 gmarinho2 commented Jun 18, 2025

Description

Add tests to check if dummy requests are created when there is only one sequence prompt scheduled and removed when a second true request is received.

Related Issues

#204

Copy link

👋 Hi! Thank you for contributing to vLLM support on Spyre.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, first install the linting requirements, then run format.sh and commit the changes. This can be done with uv directly:

uv sync --frozen --group lint --active --inexact

Or this can be done with pip:

uv pip compile --group lint > requirements-lint.txt
pip install -r requirements-lint.txt
bash format.sh

Now you are good to go 🚀

@gmarinho2 gmarinho2 closed this Jun 18, 2025
@gmarinho2 gmarinho2 reopened this Jun 18, 2025
@yannicks1
Copy link
Collaborator

Hi @gmarinho2, this PR does not look ready yet, do you mind to convert it to a draft while still working on it. Otherwise code owners get notifications to review...

@gmarinho2 gmarinho2 marked this pull request as draft June 19, 2025 12:50
@gmarinho2 gmarinho2 closed this Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants