Skip to content

✅ add tokenizer option for testing #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Conversation

prashantgupta24
Copy link
Collaborator

@prashantgupta24 prashantgupta24 commented Jun 19, 2025

Description

Add VLLM_SPYRE_TEST_TOKENIZER_LIST as an optional parameter while testing. This is used by tiny-granite models which need to supply tokenizer as an additional input to vllm.

export VLLM_SPYRE_TEST_MODEL_LIST=tiny-granite
export VLLM_SPYRE_TEST_TOKENIZER_LIST=ibm-granite/granite-3.2-8b-Instruct 

then

pytest -v -m "spyre and cb" tests

will start with

test_cb_handling[max_num_seqs(4)-num_prompts(4)-eager-model(models/tiny-granite), tokenizer(ibm-granite/granite-3.2-8b-Instruct)]
.
.
.

Also changes max_model_len to 256 in CB tests.

Signed-off-by: Prashant Gupta <[email protected]>
Copy link

👋 Hi! Thank you for contributing to vLLM support on Spyre.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, first install the linting requirements, then run format.sh and commit the changes. This can be done with uv directly:

uv sync --frozen --group lint --active --inexact

Or this can be done with pip:

uv pip compile --group lint > requirements-lint.txt
pip install -r requirements-lint.txt
bash format.sh

Now you are good to go 🚀

@@ -44,6 +45,8 @@
],
ids=lambda val: f"num_prompts({len(val)})",
)
@pytest.mark.parametrize("max_num_seqs", [2, 3, 4],
ids=lambda val: f"max_num_seqs({val})")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want this to be changed less frequently while parameterizing tests

Signed-off-by: Prashant Gupta <[email protected]>
Signed-off-by: Prashant Gupta <[email protected]>
@prashantgupta24 prashantgupta24 changed the title 🚧 changes for tiny-granite 🚧 add tokenizer option for testing Jun 20, 2025
Signed-off-by: Prashant Gupta <[email protected]>
Signed-off-by: Prashant Gupta <[email protected]>
Signed-off-by: Prashant Gupta <[email protected]>
@prashantgupta24 prashantgupta24 marked this pull request as ready for review June 20, 2025 20:15
"9 8 7 6",
],
[
"7 6 5 4",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added prompt with len=1 for testing

@prashantgupta24 prashantgupta24 changed the title 🚧 add tokenizer option for testing ✅ add tokenizer option for testing Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants