Skip to content

[v0] replace current_platform with SpyrePlatform #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025

Conversation

yannicks1
Copy link
Collaborator

[v0] replace current_platform with SpyrePlatform

PR #47 missed replacing current_platform with SpyrePlatform in the v0 model runner. I don't think this is an issue or related to the recent failures of v0 static batching on AIU Spyre, just add it here for completeness.

@yannicks1
Copy link
Collaborator Author

@joerunde could we easily use the comment bot to launch v0 SB tests on AIU Spyre with the latest image (where it was failing previously) or have v0 decoder models been completely removed from the testing pipeline?

Copy link

👋 Hi! Thank you for contributing to vLLM support on Spyre.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, first install the linting requirements, then run format.sh and commit the changes. This can be done with uv directly:

uv sync --frozen --group lint --active --inexact

Or this can be done with pip:

uv pip compile --group lint > requirements-lint.txt
pip install -r requirements-lint.txt
bash format.sh

Now you are good to go 🚀

@joerunde
Copy link
Collaborator

@yannicks1 yeah you can use the bot here. Decoder support has been completely removed from V0, but the model runner is still used for embeddings

@joerunde
Copy link
Collaborator

bot:test
MARKERS=embedding

1 similar comment
@joerunde
Copy link
Collaborator

bot:test
MARKERS=embedding

Copy link
Collaborator

@joerunde joerunde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests LGTM!

@joerunde joerunde merged commit eceda52 into main Jun 25, 2025
19 checks passed
@joerunde joerunde deleted the ysc-fix-SpyrePlatform-import branch June 25, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants