Skip to content

[CB] remove reference to outdated fms feature branch #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2025

Conversation

yannicks1
Copy link
Collaborator

[CB] remove reference to outdated fms feature branch

paged_attn_mock branch of fms is no longer needed and API on main supports both, static and continuous batching simultaneously #162

Copy link

👋 Hi! Thank you for contributing to vLLM support on Spyre.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, first install the linting requirements, then run format.sh and commit the changes. This can be done with uv directly:

uv sync --frozen --group lint --active --inexact

Or this can be done with pip:

uv pip compile --group lint > requirements-lint.txt
pip install -r requirements-lint.txt
bash format.sh

Now you are good to go 🚀

@yannicks1 yannicks1 marked this pull request as ready for review June 30, 2025 17:34
@yannicks1 yannicks1 requested review from wallashss and prashantgupta24 and removed request for prashantgupta24 June 30, 2025 17:34
Copy link
Collaborator

@prashantgupta24 prashantgupta24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@yannicks1 yannicks1 merged commit 20ed335 into main Jul 1, 2025
18 checks passed
@yannicks1 yannicks1 deleted the ysc-remove-outdated-comments branch July 1, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants