Skip to content

[Docs] Remove xgrammar install step #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2025

Conversation

rafvasq
Copy link
Collaborator

@rafvasq rafvasq commented Jul 2, 2025

Related Issues

Closes #272

Signed-off-by: Rafael Vasquez <[email protected]>
Copy link

github-actions bot commented Jul 2, 2025

👋 Hi! Thank you for contributing to vLLM support on Spyre.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, first install the linting requirements, then run format.sh and commit the changes. This can be done with uv directly:

uv sync --frozen --group lint --active --inexact

Or this can be done with pip:

uv pip compile --group lint > requirements-lint.txt
pip install -r requirements-lint.txt
bash format.sh

Now you are good to go 🚀

@rafvasq rafvasq requested a review from prashantgupta24 July 2, 2025 14:51
@rafvasq rafvasq merged commit 507c28c into vllm-project:main Jul 2, 2025
18 checks passed
@prashantgupta24
Copy link
Collaborator

Well ideally we should have merged after merging the latest vllm which has this change but 🤷 😄

@rafvasq rafvasq deleted the remove-xgrammar branch July 2, 2025 16:18
@rafvasq
Copy link
Collaborator Author

rafvasq commented Jul 2, 2025

@prashantgupta24 oops I just assumed, should've double checked 😅 -- but yeah in this case 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xgrammar now included for arm64 with vllm:main
3 participants