Skip to content

⚗️ add more prompts and cpu validation #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2025
Merged

Conversation

joerunde
Copy link
Collaborator

@joerunde joerunde commented Jul 2, 2025

Description

This updates the offline cb example test script to:

  • add more varied prompts for better testing with different --max-num-seqs values
  • add a --num-prompts option to send more prompts to the model
  • add a --compare-with-cpu flag to run the same prompts against the transformers model on cpu and ensure the text is identical

Copy link

github-actions bot commented Jul 2, 2025

👋 Hi! Thank you for contributing to vLLM support on Spyre.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, first install the linting requirements, then run format.sh and commit the changes. This can be done with uv directly:

uv sync --frozen --group lint --active --inexact

Or this can be done with pip:

uv pip compile --group lint > requirements-lint.txt
pip install -r requirements-lint.txt
bash format.sh

Now you are good to go 🚀

Copy link
Collaborator

@yannicks1 yannicks1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (did not run it tho)

Comment on lines +17 to +18
parser.add_argument("--max_model_len",
"--max-model-len",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice:)

@joerunde
Copy link
Collaborator Author

joerunde commented Jul 2, 2025

Alright, I'll go ahead and merge and we'll get this over to the compiler team today

@joerunde joerunde merged commit 3172162 into main Jul 2, 2025
18 checks passed
@joerunde joerunde deleted the cb-script-test-updates branch July 2, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants