Skip to content

[tests] add cb parameterization #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 8, 2025
Merged

[tests] add cb parameterization #289

merged 7 commits into from
Jul 8, 2025

Conversation

prashantgupta24
Copy link
Collaborator

Description

Add cb parameterization to tests/e2e/test_spyre_max_new_tokens.py

Signed-off-by: Prashant Gupta <[email protected]>
Copy link

github-actions bot commented Jul 8, 2025

👋 Hi! Thank you for contributing to vLLM support on Spyre.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, first install the linting requirements, then run format.sh and commit the changes. This can be done with uv directly:

uv sync --frozen --group lint --active --inexact

Or this can be done with pip:

uv pip compile --group lint > requirements-lint.txt
pip install -r requirements-lint.txt
bash format.sh

Now you are good to go 🚀

Signed-off-by: Prashant Gupta <[email protected]>
Signed-off-by: Prashant Gupta <[email protected]>
Signed-off-by: Prashant Gupta <[email protected]>
@prashantgupta24 prashantgupta24 changed the title 🎨 add cb parameterization [tests] add cb parameterization Jul 8, 2025
Signed-off-by: Prashant Gupta <[email protected]>
@joerunde
Copy link
Collaborator

joerunde commented Jul 8, 2025

bot:test
MARKERS="cb and spyre"

@joerunde joerunde enabled auto-merge (squash) July 8, 2025 18:52
@github-actions github-actions bot added the ready label Jul 8, 2025
@joerunde
Copy link
Collaborator

joerunde commented Jul 8, 2025

bot:test
MARKERS="spyre and not cb and not quantized and not multi"

Copy link
Collaborator

@sducouedic sducouedic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Prashant Gupta <[email protected]>
@joerunde joerunde merged commit 911874e into main Jul 8, 2025
17 checks passed
@joerunde joerunde deleted the test-max-tokens-cb branch July 8, 2025 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants