Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Model] Add T5 model (2/2) #11901

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Conversation

NickLucche
Copy link
Contributor

@NickLucche NickLucche commented Jan 9, 2025

Add support fot T5 (encoder-decoder model).
Follow-up and based on #11334, so it needs this other PR merged before it can be addressed, as it assumes to have a backend that supports passing a custom attention bias in both prefill and decode (xformers+pagedattention as of now).

Some topics I'd like to discuss here:

  • xFormers is a hard dependency for T5 as of now, do we silently enforce the backend or just raise an error? Surely we need to raise one on platforms xformers does not support (rocm)
  • T5 uses the same decoder_start_token_id as it does for padding, but there's no explicit BOS. Current logic in preprocess.py would just crash. Is this the best approach to handle the quirk of T5?
  • change to xformers.py I'd rather have been able to spare this one, but it was assuming alibi_slopes were the only way to have multiple attention biases (one per sequence).

Signed-off-by: NickLucche <[email protected]>
Signed-off-by: NickLucche <[email protected]>
Signed-off-by: NickLucche <[email protected]>
Signed-off-by: NickLucche <[email protected]>
Signed-off-by: NickLucche <[email protected]>
Signed-off-by: NickLucche <[email protected]>
Signed-off-by: NickLucche <[email protected]>
Signed-off-by: NickLucche <[email protected]>
Signed-off-by: NickLucche <[email protected]>
Copy link

github-actions bot commented Jan 9, 2025

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@@ -2,170 +2,12 @@
Run `pytest tests/models/encoder_decoder/language/test_bart.py`.
"""
from typing import List, Optional, Tuple, Type

import pytest
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can drop this folder altogether, ../language/language was never really great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant