-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Model] Add T5 model (2/2) #11901
base: main
Are you sure you want to change the base?
[Model] Add T5 model (2/2) #11901
Conversation
Signed-off-by: NickLucche <[email protected]>
Signed-off-by: NickLucche <[email protected]>
Signed-off-by: NickLucche <[email protected]>
Signed-off-by: NickLucche <[email protected]>
Signed-off-by: NickLucche <[email protected]>
Signed-off-by: NickLucche <[email protected]>
Signed-off-by: NickLucche <[email protected]>
Signed-off-by: NickLucche <[email protected]>
Signed-off-by: NickLucche <[email protected]>
Signed-off-by: NickLucche <[email protected]>
Signed-off-by: NickLucche <[email protected]>
Signed-off-by: NickLucche <[email protected]>
Signed-off-by: NickLucche <[email protected]>
Signed-off-by: NickLucche <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
Signed-off-by: NickLucche <[email protected]>
Signed-off-by: NickLucche <[email protected]>
@@ -2,170 +2,12 @@ | |||
Run `pytest tests/models/encoder_decoder/language/test_bart.py`. | |||
""" | |||
from typing import List, Optional, Tuple, Type | |||
|
|||
import pytest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can drop this folder altogether, ../language/language
was never really great
Add support fot T5 (encoder-decoder model).
Follow-up and based on #11334, so it needs this other PR merged before it can be addressed, as it assumes to have a backend that supports passing a custom attention bias in both prefill and decode (xformers+pagedattention as of now).
Some topics I'd like to discuss here:
decoder_start_token_id
as it does for padding, but there's no explicit BOS. Current logic inpreprocess.py
would just crash. Is this the best approach to handle the quirk of T5?xformers.py
I'd rather have been able to spare this one, but it was assuming alibi_slopes were the only way to have multiple attention biases (one per sequence).