[V1] APC + prompt logprobs unsupported (PR 2/N for v1 sample and prompt logprobs support) #11910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
January 2, 2025 13:15
Signed-off-by: Nick Hill <[email protected]>
Signed-off-by: Andrew Feldman <[email protected]>
…ut; *almost* passing logprobs processor unit tests Signed-off-by: Andrew Feldman <[email protected]>
Signed-off-by: Andrew Feldman <[email protected]>
Signed-off-by: Andrew Feldman <[email protected]>
Signed-off-by: Andrew Feldman <[email protected]>
Signed-off-by: Andrew Feldman <[email protected]>
Signed-off-by: Andrew Feldman <[email protected]>
Signed-off-by: Andrew Feldman <[email protected]>
Signed-off-by: Andrew Feldman <[email protected]>
Signed-off-by: Andrew Feldman <[email protected]>
Signed-off-by: Andrew Feldman <[email protected]>
Signed-off-by: Andrew Feldman <[email protected]>
Signed-off-by: Andrew Feldman <[email protected]>
Signed-off-by: Andrew Feldman <[email protected]>
Signed-off-by: Andrew Feldman <[email protected]>
Signed-off-by: Andrew Feldman <[email protected]>
Signed-off-by: Andrew Feldman <[email protected]>
Signed-off-by: Andrew Feldman <[email protected]>
|
This pull request has merge conflicts that must be resolved before it can be |
|
@afeldman-nm can this one be closed now that it's been incorporated into #9880? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR forces the v1
LLMEngineandAsyncLLMto fail ingenerate()if a request with prompt logprobs enabled arrives and the engine has prefix caching enabled. Note that while it is possible for prompt logprobs and APC to be compatible, this is left to future work.This is part of a broader vllm v1 + logprobs workstream:
PR no. 1 (#9880 ) is a dependency of this PR; it adds the infrastructure for sample and prompt logprobs support with limited unit tests
PR no. 2 is this PR
PR no. 3 will port test_completion.py logprobs tests to v1, make any adjustments required to make these tests pass, and fix a compatibility issue with Mistral tokenizer