-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Misc]add coding benchmark for speculative decoding #15303
base: main
Are you sure you want to change the base?
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you and LGTM!
For your references, here are the statistics about the input / output lengths (number of tokens) in this dataset. Not sure whether you want to change DEFAULT_OUTPUT_LEN accordingly
avg | min | max | |
---|---|---|---|
instruction + input | 151 | 15 | 837 |
output | 179 | 9 | 1317 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @ywang96 please also take a look in case I miss anything!
Also, I'm just wondering if it's possible to share some simple benchmark results on the instructcoder dataset, really appreciate it!
|
||
# ----------------------------------------------------------------------------- | ||
# Instruct Coder Dataset Implementation | ||
# ----------------------------------------------------------------------------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add simple description about the dataset, such as 'it includes code-editing tasks such as comment insertion, code optimization, and code refactoring.'
add likaixin/InstructCoder for speculative decoding benchmark throughput
to run instruct coder benchmark:
to run random benchmark: