Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc]add coding benchmark for speculative decoding #15303

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

CXIAAAAA
Copy link

@CXIAAAAA CXIAAAAA commented Mar 21, 2025

add likaixin/InstructCoder for speculative decoding benchmark throughput

to run instruct coder benchmark:

VLLM_WORKER_MULTIPROC_METHOD=spawn VLLM_USE_V1=1  python3 benchmarks/benchmark_throughput.py --dataset-name=instructcoder --model <you hf model> --input-len 1000 --output-len 100 --num-prompts 2048 --async-engine

to run random benchmark:

VLLM_WORKER_MULTIPROC_METHOD=spawn VLLM_USE_V1=1  python3 benchmarks/benchmark_throughput.py --dataset-name=random --model <you hf model> --input-len 1000 --output-len 100 --num-prompts 2048 --async-engine

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link

@youran-qi youran-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and LGTM!

For your references, here are the statistics about the input / output lengths (number of tokens) in this dataset. Not sure whether you want to change DEFAULT_OUTPUT_LEN accordingly

avg min max
instruction + input 151 15 837
output 179 9 1317

Copy link
Collaborator

@LiuXiaoxuanPKU LiuXiaoxuanPKU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @ywang96 please also take a look in case I miss anything!

Also, I'm just wondering if it's possible to share some simple benchmark results on the instructcoder dataset, really appreciate it!


# -----------------------------------------------------------------------------
# Instruct Coder Dataset Implementation
# -----------------------------------------------------------------------------
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add simple description about the dataset, such as 'it includes code-editing tasks such as comment insertion, code optimization, and code refactoring.'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants