Skip to content

Conversation

@yaochengji
Copy link
Collaborator

@yaochengji yaochengji commented Apr 6, 2025

This update can fix the performance degradation caused by the incorrect block sizes of the ragged attention kernel.

Signed-off-by: Chengji Yao <[email protected]>
@github-actions
Copy link

github-actions bot commented Apr 6, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Collaborator

@alexm-redhat alexm-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@alexm-redhat alexm-redhat enabled auto-merge (squash) April 6, 2025 17:41
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 6, 2025
@mgoin
Copy link
Member

mgoin commented Apr 6, 2025

BTW will there be python 3.12 builds soon for torch xla?

@alexm-redhat alexm-redhat merged commit 9bde5ba into vllm-project:main Apr 6, 2025
42 checks passed
@yaochengji
Copy link
Collaborator Author

BTW will there be python 3.12 builds soon for torch xla?

Thanks for mentioning this. I created an issue pytorch/xla#8946 and with coordinate with PyTorch/XLA team to support this.

lengrongfu pushed a commit to lengrongfu/vllm that referenced this pull request Apr 7, 2025
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
Signed-off-by: Chengji Yao <[email protected]>
Signed-off-by: Yang Wang <[email protected]>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Signed-off-by: Chengji Yao <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants