-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
[Bugfix] Fix v1/spec_decode/test_ngram.py #16895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Summary: Fix v1/spec_decode/test_ngram.py which is currently broken in trunk Test Plan: Reviewers: Subscribers: Tasks: Tags: Signed-off-by: qizixi <[email protected]>
99c218a to
f7fab68
Compare
WoosukKwon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the fix. Just realized that v1/spec_decode was omitted from the tests.
Signed-off-by: qizixi <[email protected]> Signed-off-by: Yang Wang <[email protected]>
Signed-off-by: qizixi <[email protected]> Signed-off-by: Frieda (Jingying) Huang <[email protected]>
Signed-off-by: qizixi <[email protected]>
Signed-off-by: qizixi <[email protected]>
Signed-off-by: qizixi <[email protected]> Signed-off-by: Agata Dobrzyniewicz <[email protected]>
Signed-off-by: qizixi <[email protected]> Signed-off-by: Mu Huai <[email protected]>
Fix v1/spec_decode/test_ngram.py which is currently broken in trunk
Test Plan:
Before:
After: