[DP] Copy environment variables to Ray DPEngineCoreActors

[ruisearch42]

Essential Elements of an Effective PR Description Checklist

• The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
• The test plan, such as providing test command.
• The test results, such as pasting the results comparison before and after, or e2e results
• (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

Currently vLLM environment variables are not passed down to DP engine cores, therefore they cannot be used to control various behavior.

This PR adds the functionality to pass down the env vars from RayDPClient to DPEngineCoreActor. It also refactors env var passing from RayDistributedExecutor to Ray workers to use the same utils method.

This PR also adds a ray directory in preparation for moving ray related functionality there, now that ray is not only used in the distributed executor but also in a larger scope such as DP.

Test Plan

Manually tested

Test Result

Test passed

(Optional) Documentation Update

[gemini-code-assist]

Summary of Changes

Hello @ruisearch42, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the distributed execution capabilities by ensuring that vLLM environment variables are correctly propagated to Ray DPEngineCoreActors, which was a previously identified limitation. It also improves the overall code maintainability and organization by centralizing environment variable handling logic into a reusable utility and by reorganizing the project structure to better accommodate future Ray-related developments.

Highlights

• Environment Variable Propagation: Enabled vLLM environment variables to be passed from the RayDPClient to DPEngineCoreActors, resolving a limitation where these variables were not previously propagated, which is crucial for controlling various behaviors in distributed setups.
• Code Refactoring and Reusability: Refactored the existing logic for passing environment variables to Ray workers within RayDistributedExecutor to leverage a new, centralized utility method (get_env_vars_to_copy), promoting code reuse and maintainability.
• Directory Structure Update: Introduced a new vllm/ray directory to consolidate Ray-related functionalities, preparing the codebase for future expansions of Ray's usage beyond just the distributed executor.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This PR centralizes environment variable management for Ray actors. It refactors RayDistributedExecutor and adds functionality for DPEngineCoreActor. The review focuses on vllm/ray/ray_env.py, suggesting error handling for JSON parsing and improvements to get_env_vars_to_copy.

[github-actions]

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

[ruisearch42]

Hi @njhill @youkaichao @kouroshHakha can I get a review? thanks

[mergify]

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @ruisearch42.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

[simon-mo]

why is this there in the first place? is there really a need to customize it?

[simon-mo]

stamping, but the patterns for file look up seems excessive see comment