[Misc] Add rules to label Speculative Decoding Related PRs #20405
Conversation
Signed-off-by: Lifan Shen <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @draftbk, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request refines the automated labeling system by updating the Mergify configuration. My aim is to ensure that all pull requests touching files relevant to speculative decoding, including new module versions, examples, and specific model implementations, are consistently and automatically tagged with the appropriate label for better organization and tracking.
Highlights
- Automation Rule Expansion: I have expanded the conditions for automatically applying the 'speculative-decoding' label to pull requests within the
.github/mergify.ymlconfiguration. - Comprehensive File Pattern Inclusion: The updated rule now includes a broader set of file paths and patterns. This covers new
v1directories for speculative decoding, various example scripts (e.g.,spec_decode,mlpspeculator,eagle,speculation), and specific model/config files related toeagle,mlp_speculator, andmedusa.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
.github/mergify.yml
Outdated
| - files~=vllm/transformers_utils/configs/eagle.py | ||
| - files~=vllm/transformers_utils/configs/medusa.py |
There was a problem hiding this comment.
The regular expressions for eagle.py and medusa.py config files are not anchored with ^. This could lead to incorrect matches for file paths that contain these strings but are not the exact files intended. Since these are exact file paths, it's better and safer to use the = operator for an exact match, just as you did for mlp_speculator.py on line 171.
- files=vllm/transformers_utils/configs/eagle.py
- files=vllm/transformers_utils/configs/medusa.py
There was a problem hiding this comment.
good suggestion, will do
.github/mergify.yml
Outdated
| - files~=^examples/.*spec_decode.*\.py | ||
| - files~=^examples/.*mlpspeculator.*\.py | ||
| - files~=^examples/.*eagle.*\.py | ||
| - files~=^examples/.*speculation.*\.py |
There was a problem hiding this comment.
These four patterns for matching example files are a bit redundant and can be combined into a single, more concise regular expression. This will improve the readability and maintainability of the configuration file.
- files~=^examples/.*(spec_decode|mlpspeculator|eagle|speculation).*\.py
There was a problem hiding this comment.
good suggestion, will do
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.Purpose
Add rules to label Speculative Decoding Related PRs
Test Plan
Test Result
(Optional) Documentation Update