-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Misc] Add rules to label Speculative Decoding Related PRs #20406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Lifan Shen <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @draftbk, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the repository's Mergify configuration to improve the automatic labeling of pull requests related to speculative decoding. The changes ensure that a broader set of relevant files, including new v1
directories, examples, and specific model implementations, trigger the appropriate label, streamlining PR organization and review processes.
Highlights
- Automated Labeling: Expanded the conditions for automatically applying the 'Speculative Decoding' label to pull requests. This includes new paths for
v1
specific speculative decoding components, related test files, example scripts, and model configurations foreagle
,medusa
, andmlp_speculator
.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This PR adds new rules to Mergify for automatically labeling pull requests related to speculative decoding. The new rules cover more files and directories. My review focuses on improving the precision and completeness of these new rules. I've suggested refining the regular expressions for better accuracy and adding rules for other speculative decoding models that appear to be missing, to ensure all relevant PRs are labeled correctly.
- files=vllm/model_executor/layers/spec_decode_base_sampler.py | ||
- files~=^tests/spec_decode/ | ||
- files~=^tests/v1/spec_decode/ | ||
- files~=^examples/.*(spec_decode|mlpspeculator|eagle|speculation).*\.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This regex can be made more precise and comprehensive. Consider including ngram
and mtp
methods, using speculative
instead of speculation
for better specificity, and anchoring the regex with $
to match the end of the filename.
- files~=^examples/.*(spec_decode|speculative|mlpspeculator|eagle|ngram|mtp).*.py$
- files=vllm/model_executor/layers/spec_decode_base_sampler.py | ||
- files~=^tests/spec_decode/ | ||
- files~=^tests/v1/spec_decode/ | ||
- files~=^examples/.*(spec_decode|mlpspeculator|eagle|speculation).*\.py | ||
- files~=^vllm/model_executor/models/.*eagle.*\.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- files~=^examples/.*(spec_decode|mlpspeculator|eagle|speculation).*\.py | ||
- files~=^vllm/model_executor/models/.*eagle.*\.py | ||
- files=vllm/model_executor/models/mlp_speculator.py | ||
- files~=^vllm/transformers_utils/configs/(eagle|medusa|mlp_speculator)\.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This regex should also be anchored to the end of the string with $
to prevent matching files with extra extensions. Additionally, to ensure comprehensive labeling for speculative decoding models, consider adding deepseek_vl2
to this regex, as it is the configuration for the deepseek_mtp
model type.
- files~=^vllm/transformers_utils/configs/(eagle|medusa|mlp_speculator|deepseek_vl2)\.py$
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.Purpose
Add rules to label Speculative Decoding Related PRs
Test Plan
Test Result
(Optional) Documentation Update