Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Add a cross-plank example (WIP) #52

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jooskim
Copy link
Collaborator

@jooskim jooskim commented May 11, 2022

Signed-off-by: Josh Kim [email protected]

@codecov-commenter
Copy link

codecov-commenter commented May 11, 2022

Codecov Report

Merging #52 (96ea6b1) into main (9ad7c33) will increase coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
+ Coverage   87.31%   87.42%   +0.11%     
==========================================
  Files          52       52              
  Lines        2704     2704              
==========================================
+ Hits         2361     2364       +3     
+ Misses        343      340       -3     
Flag Coverage Δ
unittests 87.42% <ø> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
bus/transaction.go 92.39% <0.00%> (+1.08%) ⬆️
service/service_registry.go 94.59% <0.00%> (+2.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ad7c33...96ea6b1. Read the comment docs.

Copy link
Collaborator

@daveshanley daveshanley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @jooskim

@daveshanley
Copy link
Collaborator

You might want to re-add me as having the ability to review PRs. I don't have write access to this repo anymore. :/

@jooskim
Copy link
Collaborator Author

jooskim commented May 12, 2022

Yeah I'm pissed that you got kicked off :( I added you back, hopefully we won't have to deal with this again!

@daveshanley
Copy link
Collaborator

Corporate policy, it's cool. This code belongs to the internet now, so we're all good :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants