Skip to content

Private/main/jayanth/add tc build dependency #901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jayanth-tjvrr
Copy link

This PR reads the byohImage value from TC build dependency using kustomize patch.

Testing:

Built an capi chart with the edited byoh-chart from this private branch and upgraded an existing setup.

We see that the patch is being applied:

client.go:693: [debug] Patch Service "kaapi-management-plane-kamaji-metrics-service" in namespace kaapi
client.go:693: [debug] Patch Service "kaapi-management-plane-kamaji-webhook-service" in namespace kaapi
client.go:684: [debug] Looks like there are no changes for Service "webhook-service"
client.go:684: [debug] Looks like there are no changes for Service "mysql"
client.go:684: [debug] Looks like there are no changes for Deployment "barista-controller-manager"
client.go:693: [debug] Patch Deployment "byoh-controller-manager" in namespace kaapi
client.go:684: [debug] Looks like there are no changes for Deployment "kaapi-management-plane-cluster-api-operator"
client.go:684: [debug] Looks like there are no changes for Deployment "hcp-controller-manager"
client.go:693: [debug] Patch Deployment "kaapi-management-plane-kamaji" in namespace kaapi
client.go:684: [debug] Looks like there are no changes for Deployment "addon-controller"
client.go:684: [debug] Looks like there are no changes for Deployment "access-manager"

and the image is getting reflected in byoh-controller-pod:

    env:
    - name: MANUAL_CSR_APPROVAL
      value: ${MANUAL_CSR_APPROVAL:=disable}
    image: 703671907089.dkr.ecr.us-west-2.amazonaws.com/quay.io/platform9/byoh-controller-manager:0.1.14
    imagePullPolicy: IfNotPresent
    name: manager
    ports:
    - containerPort: 9443
      name: webhook-server
      protocol: TCP

Jayanth Reddy and others added 15 commits February 26, 2025 01:36
- bundled repo for 1.26 kube
- Sample yamls for byoh config with service account
- Webhook fix to allow sevice account user
- Fix to avoid same secret name for install & bootstrap
This reverts commit 8db3384.
* Added chart-generator

* Added Byoh-chart

* increased cpu and memory limit

* removed unnecessary fields from kustomization.yaml , changed comparision of userName and managerServiceAccount in byohost_webhook controller , changed cpu memory range , changed path in kustomizeconfig.yaml

* reverted kustomization.yaml

* changes added to pr

* reverted kustomization.yaml

* Added byoh and tested

* added validation for string len check byohost_webhook.go

* reverted changes of webhook

* changes in chart-generator.sh

* removed allowance of req v1.update

* added substrs len check

---------

Co-authored-by: Snehal Shelke <[email protected]>
…deb (#5)

---------

Co-authored-by: snslk <[email protected]>
Co-authored-by: Snehal Shelke <[email protected]>
* k8s bundle
---------

Co-authored-by: Snehal Shelke <[email protected]>
…-image-build-script

add build script for controller manager
…Error

Fixed CREATE/UPDATE function in webhook configuration of BYOH
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants