KAAP-784: Add exclud-node-drain annotation on the Machine if last node while deauth/decom #904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- bundled repo for 1.26 kube - Sample yamls for byoh config with service account - Webhook fix to allow sevice account user - Fix to avoid same secret name for install & bootstrap
…izable, More specific logging to file
… kubeconfig at only one place
This reverts commit 8db3384.
Webhook and naming conflict fix in BYOH
* Added chart-generator * Added Byoh-chart * increased cpu and memory limit * removed unnecessary fields from kustomization.yaml , changed comparision of userName and managerServiceAccount in byohost_webhook controller , changed cpu memory range , changed path in kustomizeconfig.yaml * reverted kustomization.yaml * changes added to pr * reverted kustomization.yaml * Added byoh and tested * added validation for string len check byohost_webhook.go * reverted changes of webhook * changes in chart-generator.sh * removed allowance of req v1.update * added substrs len check --------- Co-authored-by: Snehal Shelke <[email protected]>
…deb (#5) --------- Co-authored-by: snslk <[email protected]> Co-authored-by: Snehal Shelke <[email protected]>
* k8s bundle --------- Co-authored-by: Snehal Shelke <[email protected]>
…stants for kubeconfig
…-image-build-script add build script for controller manager
…l decommission (#24) Co-authored-by: Snehal Shelke <[email protected]>
Ubuntu22 support for BYOH nodes
changed default kube-version to latest support version (1.32.2)
#23) * KAAP-485: Support for De-auth and Decommission host from byoh cluster --------- Co-authored-by: Vaibhav Dubewar <[email protected]>
…sioning Added versioning for byohctl
…#28) Co-authored-by: Vaibhav Dubewar <[email protected]>
Co-authored-by: Vaibhav Dubewar <[email protected]>
Co-authored-by: Vaibhav Dubewar <[email protected]>
…lector Listing only hosts from same NS to attach
#32) * kaap-553: Proceed with host cleanup in case of decommission even if byohost doesn't exist in mgmt plane * consolidated func to perform cleanup when machineRef is unset --------- Co-authored-by: Vaibhav Dubewar <[email protected]>
KAAP-537 : BYOH enhancements (Updated flags to be consistent with cloudctl, interactive password input)
…etion of byohost object when byoMachine does not exists in the cluster (#34) Co-authored-by: Vaibhav Dubewar <[email protected]>
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.17.0 to 0.35.0. - [Commits](golang/crypto@v0.17.0...v0.35.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-version: 0.35.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ost objects (#37) * Allowing users of type <name>@<domain>.<tld> to patch byohost objects * Added unit test for the same * Deny request from unauthorized-user --------- Co-authored-by: Vaibhav Dubewar <[email protected]>
… cluster deletion (#38) Co-authored-by: Vaibhav Dubewar <[email protected]>
This reverts commit 47cd654. Co-authored-by: Vaibhav Dubewar <[email protected]>
…de while deauth/decom
|
@vaibhavd21, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes KAAP-784:
If the node is the last node in the k8s cluster and when we try to deauth that, the CAPI has changed some policy in draining that node. This is applicable since we have upgraded CAPI to 1.9.0 from June release.
Ref:
https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/proposals/20240930-machine-drain-rules.md
https://github.com/kubernetes-sigs/cluster-api/releases/tag/v1.9.0
If the node is the last node in the cluster, applying annotation to exclude drain before we proceed with scaling down MD in deauth.
testing -
Deauth of first node -
workload cluster status -
Pods got shifted to the only remaining node -
Deauth of second node -
workload cluster status now with 0 nodes -