[NSXServiceAccount] Watch mgmt-proxy service and reconcile all NSXSA #1019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. Let me review it. |
|
Hi @edwardbadboy @gran-vmv @liu4480 |
gran-vmv
reviewed
Feb 10, 2025
liu4480
reviewed
Feb 10, 2025
pkg/controllers/nsxserviceaccount/nsxserviceaccount_controller.go
Outdated
Show resolved
Hide resolved
liu4480
reviewed
Feb 10, 2025
pkg/controllers/nsxserviceaccount/nsxserviceaccount_controller.go
Outdated
Show resolved
Hide resolved
liu4480
reviewed
Feb 10, 2025
pkg/controllers/nsxserviceaccount/nsxserviceaccount_controller.go
Outdated
Show resolved
Hide resolved
Atish-iaf
force-pushed
the
watch_proxy_service_and_reconcile_nsxsa
branch
from
d2a15ab to
b982484
Compare
gran-vmv
reviewed
Feb 12, 2025
| r.StatusUpdater.UpdateFail(ctx, obj, err, "", updateNSXServiceAccountStatuswithError) | ||
| return ResultRequeue, err | ||
| } | ||
| r.StatusUpdater.UpdateSuccess(ctx, obj, updateNSXServiceAccountStatus) | ||
| r.StatusUpdater.IncreaseDeleteSuccessTotal() |
There was a problem hiding this comment.
Could you ask @yanjunz97 for this? I think this may be a mistake.
There was a problem hiding this comment.
I think we can remove r.StatusUpdater.IncreaseDeleteSuccessTotal() here.
@yanjunz97 could you please take a look as well ?
liu4480
reviewed
Feb 18, 2025
| // Reconcile all NSXSA if existing Service with label "mgmt-proxy.antrea-nsx.vmware.com" is updated with Service LB VIP | ||
| if oldObjHasLabel && newObjHasLabel { | ||
| // Service type updated to LB | ||
| if oldObj.Spec.Type != corev1.ServiceTypeLoadBalancer && newObj.Spec.Type == corev1.ServiceTypeLoadBalancer { |
There was a problem hiding this comment.
what if oldObj.Spec.Type != newObj.Spec.Type and both are not corev1.ServiceTypeLoadBalancer, will this be ignored, for example, service type has been changed from nodeport to clusterip
Reconcile all NSXSA whenever LB VIP is updated for mgmt-proxy. For realized NSXSA, update proxyEndpoints only if it has changed. Signed-off-by: Kumar Atish <[email protected]>
Atish-iaf
force-pushed
the
watch_proxy_service_and_reconcile_nsxsa
branch
from
b982484 to
d361378
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reconcile all existing NSXSA incase of following events of K8s service corresponding to mgmt-proxy.
While reconciling realized NSXSA, update proxyEndpoints if proxyEndpoints have changed.