Add webhook for ipaddressallocation #1134
Open
+250
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1134 +/- ##
==========================================
- Coverage 74.11% 73.03% -1.08%
==========================================
Files 137 137
Lines 21572 21702 +130
==========================================
- Hits 15988 15851 -137
- Misses 4576 4853 +277
+ Partials 1008 998 -10
🚀 New features to boost your workflow:
|
|
/e2e |
1 similar comment
|
/e2e |
|
/e2e |
TaoZou1
force-pushed
the
ipcheck
branch
2 times, most recently
from
46b7405 to
861d543
Compare
Search all the service under the same namespace. If the ip has been used in the service, operator will reject the deletion of ipaddressallocation Test Done: 1. create an ipaddressallocation with ip 192.168.0.50 2. update svc with loadBalancerIP: 192.168.0.50 3. wait for svc ready 4. delete the ipaddressallocation 5. check if return error like: Error from server (Forbidden): admission webhook "ipaddressallocation.validating.crd.nsx.vmware.com" denied the request: cannot delete IPAddressAllocation ip2: IP 192.168.0.50 is still in use by Service milk-svc
|
/e2e |
1 similar comment
|
/e2e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Search all the service under the same namespace. If the ip has been used in the service, operator will reject the deletion of ipaddressallocation
Test Done:
case 1:
"ipaddressallocation.validating.crd.nsx.vmware.com" denied the request: cannot delete IPAddressAllocation ip2: IP 192.168.0.50 is still in use by Service milk-svc
case 2:
"ipaddressallocation.validating.crd.nsx.vmware.com" denied the request: cannot delete IPAddressAllocation ip1: IP 192.168.0.55 is still in use by Service milk-svc