Skip to content

Update svc status if has error annotation #1145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TaoZou1
Copy link
Contributor

@TaoZou1 TaoZou1 commented Jul 7, 2025

Fix the svc network status/status not uploading issue if svc has ep

Test Done:

  1. create pod tea
  2. create svc with labels: app: tea which VIP has been used
  3. check inventory if networkstatus is DOWN, status is DOWN, error is reported

@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.04%. Comparing base (64f5857) to head (c596556).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1145      +/-   ##
==========================================
- Coverage   73.88%   73.04%   -0.85%     
==========================================
  Files         137      137              
  Lines       21648    21670      +22     
==========================================
- Hits        15994    15828     -166     
- Misses       4650     4847     +197     
+ Partials     1004      995       -9     
Flag Coverage Δ
unit-tests 73.04% <100.00%> (-0.85%) ⬇️
Files with missing lines Coverage Δ
pkg/nsx/services/inventory/builder.go 82.29% <100.00%> (+0.06%) ⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TaoZou1
Copy link
Contributor Author

TaoZou1 commented Jul 8, 2025

/e2e

Fix the svc network status/status not uploading issue if svc has ep
Copy link
Contributor

@timdengyun timdengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants