Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: define common aliases for k8s packages #8672

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Feb 8, 2025

Thank you for contributing to Velero!

Please add a summary of your change

define common aliases for k8s packages

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

@mmorel-35
Copy link
Contributor Author

/kind changelog-not-required

@github-actions github-actions bot added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Feb 8, 2025
Copy link

codecov bot commented Feb 8, 2025

Codecov Report

Attention: Patch coverage is 83.97626% with 54 lines in your changes missing coverage. Please review.

Project coverage is 59.48%. Comparing base (e64806a) to head (294aeab).

Files with missing lines Patch % Lines
pkg/cmd/cli/nodeagent/server.go 14.28% 6 Missing ⚠️
pkg/datapath/micro_service_watcher.go 53.84% 6 Missing ⚠️
pkg/exposer/csi_snapshot.go 85.71% 6 Missing ⚠️
pkg/exposer/generic_restore.go 80.00% 6 Missing ⚠️
pkg/restore/restore.go 79.16% 4 Missing and 1 partial ⚠️
pkg/controller/data_upload_controller.go 70.00% 2 Missing and 1 partial ⚠️
pkg/controller/restore_finalizer_controller.go 62.50% 0 Missing and 3 partials ⚠️
internal/resourcepolicies/resource_policies.go 50.00% 2 Missing ⚠️
pkg/cmd/cli/datamover/backup.go 0.00% 2 Missing ⚠️
pkg/cmd/cli/datamover/restore.go 0.00% 2 Missing ⚠️
... and 11 more
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8672   +/-   ##
=======================================
  Coverage   59.48%   59.48%           
=======================================
  Files         371      371           
  Lines       40191    40191           
=======================================
  Hits        23909    23909           
  Misses      14789    14789           
  Partials     1493     1493           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmorel-35 mmorel-35 force-pushed the golangci-lint/importas branch from 607a313 to 77f6ec6 Compare February 8, 2025 11:30
blackpiglet
blackpiglet previously approved these changes Feb 10, 2025
kaovilai
kaovilai previously approved these changes Feb 10, 2025
@mmorel-35 mmorel-35 force-pushed the golangci-lint/importas branch from 77f6ec6 to 6d8991c Compare February 11, 2025 07:16
@mmorel-35 mmorel-35 dismissed stale reviews from blackpiglet and kaovilai via 294aeab February 19, 2025 19:08
@mmorel-35 mmorel-35 force-pushed the golangci-lint/importas branch from 6d8991c to 294aeab Compare February 19, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-e2e-2tests has-unit-tests kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants