Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify golangci configuration to make it work. #8695

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

blackpiglet
Copy link
Contributor

@blackpiglet blackpiglet commented Feb 17, 2025

Thank you for contributing to Velero!

Please add a summary of your change

https://github.com/vmware-tanzu/velero/actions/runs/13363546193/job/37317100078#step:4:30
The linter check action failed after some linter PR merged.
This PR aims to resolve the failures.

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

@blackpiglet blackpiglet added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Feb 17, 2025
@blackpiglet blackpiglet removed the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Feb 17, 2025
@blackpiglet blackpiglet self-assigned this Feb 17, 2025
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.46%. Comparing base (2b0c509) to head (e736ef7).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8695      +/-   ##
==========================================
- Coverage   59.48%   59.46%   -0.02%     
==========================================
  Files         371      371              
  Lines       40191    40191              
==========================================
- Hits        23909    23901       -8     
- Misses      14789    14796       +7     
- Partials     1493     1494       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmorel-35
Copy link
Contributor

mmorel-35 commented Feb 17, 2025

For the record I proposed #8641 on 22 January.
It doesn't cover all of the modifications done here but enough to upgrade golangci-lint to 1.63.4

@blackpiglet blackpiglet marked this pull request as ready for review February 18, 2025 03:17
@blackpiglet
Copy link
Contributor Author

@mmorel-35
#8641 This PR contains more things than to fix the linter errors.
Could we fix the actions error first, then consider whether we should merge #8641?

@mmorel-35
Copy link
Contributor

That's fine for me

@reasonerjt reasonerjt merged commit e64806a into vmware-tanzu:main Feb 19, 2025
41 of 42 checks passed
@mmorel-35
Copy link
Contributor

Now that this has been merged to main branch, I just rebased #8641

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants