Skip to content

Add lint-fix make targets #9388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kaovilai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add lint-fix make targets #9388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,6 +336,16 @@ ifneq ($(SKIP_TESTS), 1)
@hack/lint.sh
endif

lint-fix:
ifneq ($(SKIP_TESTS), 1)
@$(MAKE) shell CMD="-c 'hack/lint.sh fix'"
endif

local-lint-fix:
ifneq ($(SKIP_TESTS), 1)
@hack/lint.sh fix
endif

update:
@$(MAKE) shell CMD="-c 'hack/update-all.sh'"

Expand Down
6 changes: 6 additions & 0 deletions hack/lint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,12 @@ golangci-lint cache status
# Enable GL_DEBUG line below for debug messages for golangci-lint
# export GL_DEBUG=loader,gocritic,env
CMD="golangci-lint run"

# Add --fix flag if first argument is "fix"
if [ "$1" = "fix" ]; then
CMD="$CMD --fix"
fi

echo "Running $CMD"

eval $CMD
Loading