feat: support backup hooks on native sidecars #9403
+35
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GabriFedi97
force-pushed
the
fix/hooks-on-sidecars
branch
3 times, most recently
from
252a51a to
688327c
Compare
GabriFedi97
changed the title
Author
|
Do we need to update the documentation for this patch? The Backup Hooks documentation section currently refers to containers in a general manner. Should we explicitly distinguish between main and sidecar containers? |
GabriFedi97
force-pushed
the
fix/hooks-on-sidecars
branch
from
688327c to
cf9900e
Compare
blackpiglet
previously approved these changes
Dec 10, 2025
Add support for configuring Kubernates native Sidecars as target containrs for Backup Hooks commands. This is purely a validation level patch as the actual pods/exec API doesn't make any distinction between standard and sidecar containers. Signed-off-by: Gabriele Fedi <gabriele.fedi@enterprisedb.com>
Signed-off-by: Gabriele Fedi <gabriele.fedi@enterprisedb.com>
Signed-off-by: Gabriele Fedi <gabriele.fedi@enterprisedb.com>
blackpiglet
force-pushed
the
fix/hooks-on-sidecars
branch
from
cf9900e to
181797d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9403 +/- ##
=======================================
Coverage 60.19% 60.20%
=======================================
Files 386 386
Lines 35925 35934 +9
=======================================
+ Hits 21624 21633 +9
Misses 12720 12720
Partials 1581 1581 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
blackpiglet
reviewed
Dec 10, 2025
Signed-off-by: Gabriele Fedi <gabriele.fedi@enterprisedb.com>
blackpiglet
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include Sidecar containers when validating the existence of the target containers configured for the Backup Hooks.
Does your change fix a particular issue?
Fixes #9393
Please indicate you've done the following:
make new-changelog) or comment/kind changelog-not-requiredon this PR.site/content/docs/main.