WIP: Support edit of config for running cVMs and endpointVM #8637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the generated VIC service bindings to the ingore set for linting due to package names containing underscores. This will present on all but the first build in a given build env.
The Name field was changed to be hidden from the guest in vmware#4134 to support docker rename. This was a compromise needed due to an ESX vigor bug, see vmware#5533. This *requires* that users be on a version of ESX that has the fix or bad things may happen to cVM configurations. I have not tracked down what build versions that entails and have not code a check mechanism. This change has the effect of the hostname of the VCH endpointVM being set to the name of the VCH. It also allows additional live reconfiguration such as hotadd to a bridge network, in general modification of all container configuration live is possible, if not necessarily applied.
hickeng
added
kind/enhancement
hickeng
changed the title
|
Turns out the guestinfo "fix" did not address making persistent changes to keys on a running VM via the API, so the old problems with updating a live cVM are all still present. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates config handling to make use of the fact that the bug1985862 has been addressed and in the field for a while now. That bug prevented us from using the vim API to update guestinfo keys while the VM was running as they would convert to non-persistent.
NOTE this PR should not be shipped without determining which ESX builds include that fix and a check of some kind during vic-machine install/upgrade to confirm that the target, or all current ESXs in the target cluster are of sufficiently high version.
This enables any of the blocked work such as
docker network add <bridgenet> <cid>for running containers that was previously blocked.There is a quirk in my validation of
renameafter upgrade; the rename applies in ESX but does not update the VIC metadata for the VM.If I recall correctly we had a statement about levels of support for old containers, particularly those that had never been run. I think that's what I'm seeing but haven't tracked down the support statement.
Related #5553
[full ci]