testsuite: fix invalid chars check, and image building

* pass LOG_PANIC_ON_INVALIDCHARS env var to containers * remove `profiles:` from container test because it made `docker compose build` counter-intuitive * apiclient: fix log string
vocdoni · Oct 23, 2023 · e269d78 · e269d78
1 parent 9bdef4d
commit e269d78
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/apiclient/helpers.go b/apiclient/helpers.go
@@ -166,7 +166,7 @@ func (c *HTTPclient) WaitUntilElectionStatus(ctx context.Context,
 // WaitUntilElectionResults waits until the given election has published final results.
 func (c *HTTPclient) WaitUntilElectionResults(ctx context.Context,
 	electionID types.HexBytes) (*api.ElectionResults, error) {
-	log.Infof("waiting for election %s to publish final results", electionID)
+	log.Infof("waiting for election %s to publish final results", electionID.String())
 	startTime := time.Now()
 	for {
 		election, err := c.ElectionResults(electionID)

diff --git a/dockerfiles/testsuite/docker-compose.yml b/dockerfiles/testsuite/docker-compose.yml
@@ -17,6 +17,7 @@ services:
       - gocoverage-seed:/app/run/gocoverage
     environment:
       - GOCOVERDIR=/app/run/gocoverage
+      - LOG_PANIC_ON_INVALIDCHARS
 
   miner0:
     image: "dvotenode:${TESTSUITE_BUILD_TAG:-latest}"
@@ -30,6 +31,7 @@ services:
       - gocoverage-miner0:/app/run/gocoverage
     environment:
       - GOCOVERDIR=/app/run/gocoverage
+      - LOG_PANIC_ON_INVALIDCHARS
 
   miner1:
     image: "dvotenode:${TESTSUITE_BUILD_TAG:-latest}"
@@ -43,6 +45,7 @@ services:
       - gocoverage-miner1:/app/run/gocoverage
     environment:
       - GOCOVERDIR=/app/run/gocoverage
+      - LOG_PANIC_ON_INVALIDCHARS
 
   miner2:
     image: "dvotenode:${TESTSUITE_BUILD_TAG:-latest}"
@@ -56,6 +59,7 @@ services:
       - gocoverage-miner2:/app/run/gocoverage
     environment:
       - GOCOVERDIR=/app/run/gocoverage
+      - LOG_PANIC_ON_INVALIDCHARS
 
   miner3:
     image: "dvotenode:${TESTSUITE_BUILD_TAG:-latest}"
@@ -69,6 +73,7 @@ services:
       - gocoverage-miner3:/app/run/gocoverage
     environment:
       - GOCOVERDIR=/app/run/gocoverage
+      - LOG_PANIC_ON_INVALIDCHARS
 
   gateway0:
     image: "dvotenode:${TESTSUITE_BUILD_TAG:-latest}"
@@ -84,6 +89,7 @@ services:
       - gocoverage-gateway0:/app/run/gocoverage
     environment:
       - GOCOVERDIR=/app/run/gocoverage
+      - LOG_PANIC_ON_INVALIDCHARS
 
   test:
     image: "dvotenode-test:${TESTSUITE_BUILD_TAG:-latest}"
@@ -98,9 +104,8 @@ services:
       - gocoverage-test:/app/run/gocoverage
     environment:
       - GOCOVERDIR=/app/run/gocoverage
+      - LOG_PANIC_ON_INVALIDCHARS
     command: "true"
-    profiles:
-      - tools # this container is only intended to be `docker compose run`, no need to start on `docker compose up`
 
   gocoverage:
     image: golang:1.21