Skip to content

Conversation

@riadok
Copy link

@riadok riadok commented Jan 9, 2026

Testing the changes

  • I tested the changes in this PR: briefly

New package

Local build testing

  • I built this PR locally for my native architecture, (x86_64-glibc)

Copy link
Member

@ahesford ahesford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several others have attempted to package this but have eventually lost interest. I am not aware that prior concerns have been addressed. Even if they are, there are technical problems with this template; chief among these is the use of the go build style but the replacement of all of the functions it provides with custom substitutes.

Comment on lines +35 to +37
do_install() {
vbin gitea forgejo
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A Void package should not arbitrarily rename the only executable provided by the project.

That said, unless and until upstream decides to differentiate its project enough to actually call the executable by its own name, I have a hard time considering this package suitable for inclusion.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

system_accounts="forgejo"
forgejo_homedir="/var/lib/forgejo"
# For SSH access.
forgejo_shell="/bin/bash"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As previously noted, this should probably not be enforced; however, if there is a real reason to demand bash, the package would have to depend on bash.

@tranzystorekk tranzystorekk added the new-package This PR adds a new package label Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-package This PR adds a new package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants