WIP feat: progressively load the widgets while the kernel is executing #768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will connect to the kernel as soon as possible, and tries to create widget during execution. This avoids having to get all the widgets after execution, and is an alterative to; voila-dashboards#766 Issues: * since the whole jupyter message handling is 'synchronous' it awaits at a top level and goes all the way down, get_model needs to be resolved without any new message coming from the kernel. * Despite making handle_comm_open not returning a promise, we still get a stalling of the whole message q. Despite these issues, the loading time is significantly reduced, since the page renders almost instantly when it succeeds (e.g. when no widgets are missed).
|
Note to self, we can do this a different way:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will connect to the kernel as soon as possible, and tries to create
widget during execution. This avoids having to get all the widgets after
execution, and is an alterative to:
#766
Issues:
at a top level and goes all the way down, get_model needs to be resolved
without any new message coming from the kernel.
a stalling of the whole message q.
Despite these issues, the loading time is significantly reduced, since
the page renders almost instantly when it succeeds (e.g. when no widgets
are missed).