-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix: ci err caused bt ray e2e default image #4670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary of ChangesHello @Wonki4, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical CI failure in the Ray end-to-end test suite. The issue was caused by the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This PR aims to fix a CI error by updating the default Ray image used in E2E tests. The switch from the deprecated bitnami/ray
to rayproject/ray
is the correct approach. However, the image tag 2.49.0
appears to be a typo and is invalid for the rayproject/ray
repository as well, which will cause the CI to continue failing. I've provided a suggestion for a valid tag.
Additionally, please note that example/integrations/ray/ray-example.yaml
also uses the old, invalid image bitnami/ray:2.49.0
. It would be beneficial to update it within this PR to ensure the provided example is functional.
// "volcanosh/pytorch-mnist-v1beta1-9ee8fda-example:0.0.1" is from "docker.io/kubeflowkatib/pytorch-mnist:v1beta1-9ee8fda" | ||
DefaultPytorchImage = "volcanosh/pytorch-mnist-v1beta1-9ee8fda-example:0.0.1" | ||
DefaultRayImage = "bitnami/ray:2.49.0" | ||
DefaultRayImage = "rayproject/ray:2.49.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The image rayproject/ray:2.49.0
does not exist on Docker Hub. It seems 2.49.0
is a typo that was carried over from the previous image URI. To fix the CI error, please use a valid image tag. For example, 2.9.3
is a valid and stable version.
DefaultRayImage = "rayproject/ray:2.49.0" | |
DefaultRayImage = "rayproject/ray:2.9.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://hub.docker.com/layers/rayproject/ray/2.49.0
2.49.0 is valid and stable version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://hub.docker.com/layers/rayproject/ray/2.49.0
2.49.0 is valid and stable version.
After you changed the ray image, can the flaky test be fixed? Do we still need to prune the images?
Could you share your result of #4642 about deleting docker images in test/e2e/jobseq package? |
Signed-off-by: Wongi, Baek <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if we do need this PruneUnusedImagesOnAllNodes
? Cause #4642 has already used docker system prune
to free disk. The e2e testing is running on a github runner machine, and the runner machine runs a kind cluster, do we still need to list all the k8s nodes and exec PruneUnusedImagesOnAllNodes
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw the PR and I knew that the code for prune was deleted.
The final change is related to loading vc images in control plane node.
There is some misunderstanding, #4642 just load volcano components images to control-plane node because volcano is only deployed in that node. |
What type of PR is this?
Fix ci error caused by ray default image.
What this PR does / why we need it:
When ray e2e sequence test is executed, the pod could not pull the e2e default image(bitnami/ray:2.49.0, not found)
Because bitnami no longer provide the image. bitnami/ray:2.49.0

Which issue(s) this PR fixes:
Fixes #4669
Special notes for your reviewer:
Does this PR introduce a user-facing change?