Feat/eslint a11y plugin #296
Conversation
The commit fixes several TypeScript-related issues, improves type safety, and makes type usage more consistent across multiple components. This includes proper HTMLAttributes usage, explicit HTMLTag typing, and better Props type definitions.
recommended - Because this is not cjs the flat/ prefix is not needed.
Deploying head-start with
|
| Latest commit: |
8942b4e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://95a11eb7.head-start.pages.dev |
| Branch Preview URL: | https://feat-eslint-a11y-plugin.head-start.pages.dev |
|
|
||
| <style> | ||
| ul { | ||
| list-style: none; | ||
| list-style-type: ""; |
There was a problem hiding this comment.
When using the list-style-type: ""; CSS property with an empty string value, you remove the visual list markers (bullets, numbers, etc.) while preserving the semantic meaning and accessibility properties of the list for screen readers and other assistive technologies. I've also updated the readme for the UnstyledList with this.
There was a problem hiding this comment.
I've seen or had this discussion before in head-start related projects. If I remember correctly, this solution does not work for all browsers, so resetting the styling with list-style: none; with role="list" has better cross-browser support. Moreover, in the described behaviour this component would be redundant. What is the reason behind refactoring this?
There was a problem hiding this comment.
I couldn't really find a way to make sure eslint knows it does contain a <track>. I don't know if it's because it's coming from another file or if it can be empty, so I disabled the rule for the video elements
Changes
This plugin checks for accessibility problem and forces you to use necessary attributes.
Associated issue
N.A.
How to test
Checklist
I have added a decision log entry if the change affects the architecture or changes a significant technology