Chore: Improve icon component #297
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit fixes several TypeScript-related issues, improves type safety, and makes type usage more consistent across multiple components. This includes proper HTMLAttributes usage, explicit HTMLTag typing, and better Props type definitions.
Deploying head-start with
|
| Latest commit: |
8192901
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://347a1e2a.head-start.pages.dev |
| Branch Preview URL: | https://chore-improve-icon-component.head-start.pages.dev |
bazottie
reviewed
Jul 25, 2025
Comment on lines
+18
to
+24
| data-icon={name} | ||
| role={ariaLabel ? 'img' : 'presentation'} | ||
| aria-hidden={!ariaLabel} | ||
| aria-label={ariaLabel} | ||
| {...props} | ||
| > | ||
| <use href={`#${name}`} /> |
There was a problem hiding this comment.
Are these not identical to the previous implementation besides removing xlink:href?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
My first idea was to implement the <title> element, but after some research I found out the title element isn't consistently supported by screenreaders and assistive technologies, even though it's part of the SVG specification. So I kept the aria-label approach but cleaned up the implementation.
Associated issue
N.A.
How to test
Checklist
I have made updated relevant documentation files (in project README, docs/, etc)I have added a decision log entry if the change affects the architecture or changes a significant technology