Skip to content

Refactor thruster interface #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Conversation

albertomors
Copy link

No description provided.

@albertomors albertomors self-assigned this Mar 6, 2025
@albertomors albertomors linked an issue Mar 6, 2025 that may be closed by this pull request
3 tasks
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

Attention: Patch coverage is 0% with 162 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (690c74e) to head (a966690).

Files with missing lines Patch % Lines
...nterface_asv/src/thruster_interface_asv_driver.cpp 0.00% 78 Missing ⚠️
...r_interface_asv/src/thruster_interface_asv_ros.cpp 0.00% 78 Missing ⚠️
...er_interface_asv/thruster_interface_asv_driver.hpp 0.00% 4 Missing ⚠️
..._interface_asv/src/thruster_interface_asv_node.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #205   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         12      14    +2     
  Lines        483     497   +14     
  Branches      43      37    -6     
=====================================
- Misses       483     497   +14     
Flag Coverage Δ
unittests 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
..._interface_asv/src/thruster_interface_asv_node.cpp 0.00% <0.00%> (ø)
...er_interface_asv/thruster_interface_asv_driver.hpp 0.00% <0.00%> (ø)
...nterface_asv/src/thruster_interface_asv_driver.cpp 0.00% <0.00%> (ø)
...r_interface_asv/src/thruster_interface_asv_ros.cpp 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@jorgenfj jorgenfj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Andeshog
Copy link
Contributor

Andeshog commented Mar 6, 2025

if this works in test we will merge 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] rewrite ASV thruster interface
5 participants