fix: disable ghostbuster for normal use and encapsulate into own rake task #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is a draft because had no time to test it yet, but wanted to write down my thoughts |
bastelfreak
reviewed
Mar 17, 2025
| @@ -27,5 +43,24 @@ namespace :voxpupuli do | |||
|
|
|||
| Rake::Task[:lint].invoke | |||
| end | |||
|
|
|||
| desc 'Who you gonna call? Ghostbusters!' | |||
| task :ghostbuster do | |||
There was a problem hiding this comment.
maybe add a test to the pipeline that checks if the rake task exists?
There was a problem hiding this comment.
some more testing would be nice here :D
will check what i can do about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #101