Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop support for EoL Puppet Enterprise (pe) #107

Merged
merged 1 commit into from
Sep 10, 2024
Merged

drop support for EoL Puppet Enterprise (pe) #107

merged 1 commit into from
Sep 10, 2024

Conversation

jhoblitt
Copy link
Member

No description provided.

@jhoblitt
drop Puppet Enterprise (pe) support
969a8fb 
As the pe detection logic was questionable, it has been removed.
@jhoblitt jhoblitt added the backwards-incompatible This change will lead to a major version bump for the next release label Sep 10, 2024
bastelfreak
bastelfreak approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@bastelfreak bastelfreak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only drops support for PE 2016 or older. That's EoL since ages, so I think we don't need the backwards-incompatible label.

@bastelfreak bastelfreak removed the backwards-incompatible This change will lead to a major version bump for the next release label Sep 10, 2024
@bastelfreak bastelfreak changed the title drop Puppet Enterprise (pe) support drop Puppet Enterprise (pe) support for EoL versions Sep 10, 2024
@bastelfreak bastelfreak changed the title drop Puppet Enterprise (pe) support for EoL versions drop support for EoL Puppet Enterprise (pe) Sep 10, 2024
@jhoblitt jhoblitt merged commit 44e0228 into master Sep 10, 2024
12 checks passed
@jhoblitt jhoblitt deleted the maint/drop-pe-support branch September 10, 2024 17:30
This was referenced Sep 10, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak approved these changes

@kenyon kenyon Awaiting requested review from kenyon

@smortex smortex Awaiting requested review from smortex

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhoblitt @bastelfreak