Add remove_resource function
#245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Feb 17, 2025
Comment on lines
+46
to
+49
| scope.catalog.remove_resource(catalog_resource) | ||
| scope.compiler.resources.delete(catalog_resource) |
There was a problem hiding this comment.
can you maybe write a sentence or two what's the difference of catalog vs compiler here? Do horrible things happen when other resources depend on the one that's deleted?
There was a problem hiding this comment.
scope.catalog is the same as scope.compiler.catalog.
I'll try to come up with some better explanation for these two lines though.
There was a problem hiding this comment.
Horrible things? Not really. At the end of the catalog compilation process, if any resources mentioned in relationships have been removed, you get the standard Could not find resource error.
notify { ['foo','bar']: }
Notify['foo'] -> Notify['bar']
extlib::remove_resource(Notify['foo'])Error: Could not find resource 'Notify[foo]' for relationship on 'Notify[bar]' on node example
There was a problem hiding this comment.
I've added a comment and also split out the unrelated puppet-strings fixup into its own commit.
alexjfisher
force-pushed
the
remove_resource
branch
from
b6e29af to
7afb84e
Compare
By using the `@summary` tag correctly, only that line is included in the REFERENCE function index.
alexjfisher
force-pushed
the
remove_resource
branch
from
7afb84e to
ee8a531
Compare
bastelfreak
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.