Fix remove_resource Attempt to redefine entity
#247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation used to find the resource in the catalog was causing the following style of error on the Puppetserver. ``` Server Error: Evaluation Error: Error while evaluating a Function Call, Could not autoload puppet/type/file_line: Attempt to redefine entity 'http://puppet.com/2016.1/runtime/type/file_line' ``` This only occurred the first time trying to compile the catalog. Subsequent runs against the same puppetserver would work fine. I don't fully understand what was causing the type to be reloaded, and this was only an issue if `generate types` had been used to create the `.resource_types/*.pp` metadata file for the type. Presumably puppet is upset when it tries to load the ruby definition of a type after it's already loaded the pcore version?? In this commit, we switch to the same mechanism used by the `defined` function.
bastelfreak
approved these changes
Feb 18, 2025
alexjfisher
commented
Feb 18, 2025
| @@ -40,7 +40,8 @@ def remove_resources(scope, resources, soft_fail = nil) | |||
| end | |||
|
|
|||
| def remove_resource(scope, resource, soft_fail = nil) | |||
| catalog_resource = scope.catalog.resource(resource.type_name, resource.title) | |||
| type = Puppet::Pops::Evaluator::Runtime3ResourceSupport.find_resource_type(scope, resource.type_name) | |||
| catalog_resource = scope.compiler.findresource(type, resource.title) | |||
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation used to find the resource in the catalog was causing the following style of error on the Puppetserver.
This only occurred the first time trying to compile the catalog. Subsequent runs against the same puppetserver would work fine. I don't fully understand what was causing the type to be reloaded, and this was only an issue if
generate typeshad been used to create the.resource_types/*.ppmetadata file for the type. Presumably puppet is upset when it tries to load the ruby definition of a type after it's already loaded the pcore version??In this commit, we switch to the same mechanism used by the
definedfunction.