Realize exported Vrrp:Script resources #117
Conversation
jconroy77
force-pushed
the
collect_track_script
branch
3 times, most recently
from
80730e1 to
06c31b8
Compare
jconroy77
force-pushed
the
collect_track_script
branch
from
06c31b8 to
fa7bfac
Compare
|
If this is accepted, I also have another followup PR that will add a param $filter_on_tag for the collectors to enable filtering on the $tag metaparameter based on the value of $filter_on_tag. We do exports across datacenters, so we need to be able to filter based on a |
arioch
force-pushed
the
master
branch
2 times, most recently
from
04a3890 to
36ab576
Compare
| @@ -174,7 +181,7 @@ | |||
| $dont_track_primary = false, | |||
| $use_vmac = false, | |||
| $vmac_xmit_base = true, | |||
|
|
|||
| $collect_exported = false, | |||
There was a problem hiding this comment.
please add a datatype to the new parameter.
| @@ -185,10 +192,22 @@ | |||
| fail('virtual_router_id must be an integer >= 1 and <= 255') | |||
| } | |||
|
|
|||
| validate_bool($collect_exported) | |||
There was a problem hiding this comment.
this isn't required after adding a datatype
| $rise = undef, | ||
| $timeout = undef, | ||
| $no_weight = false, | ||
| $vrrp_instance = undef, |
There was a problem hiding this comment.
same here, please add a datatype
| @@ -0,0 +1,81 @@ | |||
| <%- if @track_script or @collect_exported -%> | |||
There was a problem hiding this comment.
could you add a comment at the top like # THIS FILE IS MANAGED BY PUPPET?
Are you interested in converting this to an epp template? That's our prefered template language (but erb works as well).
bastelfreak
added
enhancement
|
hi @jconroy77, thanks for the PR. This repository got recently migrated to us. Are you able to rebase this and take a look at the inline comments I made? |
|
Dear @jconroy77, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
2 similar comments
|
Dear @jconroy77, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
|
Dear @jconroy77, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
|
Dear @jconroy77, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
Added option to collect exported vrrp::script resources (similar to how lvs::virtual_server collects exported lvs::real_server resources) so that the real_servers can export check scripts that contain identifying information (such as IP address, etc).
The $collect_exported param is defaulted to false to avoid changing the current behavior though an empty track_script{} block doesn't appear to cause any issues when added to the config so it may be preferable to default it to true to mimic the virtual_server/real_server functionality.