-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for sorry_server_lvs_method #150
base: master
Are you sure you want to change the base?
Conversation
$real_servers = undef, | ||
$sorry_server = undef, | ||
$sorry_server_inhibit = false, | ||
$sorry_server_lvs_method = undef, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a datatype for the new parameter
@@ -38,6 +38,9 @@ virtual_server <%= @ip_address %> <%= @port %> { | |||
<%- if @sorry_server_inhibit -%> | |||
sorry_server_inhibit | |||
<%- end -%> | |||
<%- if @sorry_server_lvs_method -%> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please add a unit test to verify that this works?
Hi @mattmix, thanks for the PR! Can you please take a look at the inline comments I made? |
Dear @mattmix, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
Dear @mattmix, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
Dear @mattmix, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
This option is available in more recent versions of keepalived.