add support for garp_master_repeat and garp_interval #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
May 20, 2021
| @@ -190,6 +194,7 @@ | |||
| $advert_int = 1, | |||
| $garp_master_delay = 5, | |||
| $garp_master_refresh = undef, | |||
| $garp_master_repeat = undef, | |||
There was a problem hiding this comment.
please add a datatype for the new parameter
bastelfreak
reviewed
May 20, 2021
| @@ -206,6 +211,7 @@ | |||
| $use_vmac = false, | |||
| $vmac_xmit_base = true, | |||
| Boolean $native_ipv6 = false, | |||
|
|
|||
There was a problem hiding this comment.
was there a reason for this change? I think a puppet-lint plugin isn't happy about the new line here
bastelfreak
reviewed
May 20, 2021
| @@ -79,6 +81,7 @@ | |||
| Optional[Integer] $vrrp_garp_master_refresh = undef, | |||
| Optional[Integer] $vrrp_garp_lower_prio_delay = undef, | |||
| $snmp_socket = 'unix:/var/agentx/master', | |||
| $garp_interval = undef, | |||
There was a problem hiding this comment.
please add a datatype for the new parameter
|
@unki thanks for this PR as well. can you please take a look at the inline comments I did and add some tests? |
|
@unki ping :) |
|
Dear @unki, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for garp_master_repeat (keepalived::vrrp::instance) and garp_interval (global)