Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vrrp_instance::track_script: Fix Datatype-Mismatch #322

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

cocker-cc
Copy link
Contributor

Pull Request (PR) description

The Variant of $track_script's Datatype

Variant[Array[String[1]],String[1]] $track_script

has to get handled correctly in the ERB-File. Otherwise it fails with a single String.

This Pull Request (PR) fixes the following issues

fixes 4307d70

@cocker-cc cocker-cc force-pushed the Fix_Datatype-Mismatch branch 2 times, most recently from cdb9969 to 7b67e93 Compare March 18, 2024 18:37
@bastelfreak bastelfreak changed the title Fix Datatype-Mismatch vrrp_instance::track_script: Fix Datatype-Mismatch Mar 18, 2024
@bastelfreak
Copy link
Member

the REFERENCE.nd is outdated. you can update it with bundle exec rake strings:generate:reference

The Variant of $track_script's Datatype
```
Variant[Array[String[1]],String[1]] $track_script
```

has to get handled correctly in the ERB-File.  Otherwise it fails with a
single String.

fixes 4307d70
@cocker-cc cocker-cc force-pushed the Fix_Datatype-Mismatch branch from 7b67e93 to 350e64c Compare March 18, 2024 22:22
Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@smortex smortex added the bug Something isn't working label Mar 19, 2024
@smortex smortex merged commit 460c9ee into voxpupuli:master Mar 19, 2024
14 checks passed
bastelfreak added a commit to bastelfreak/puppet-keepalived that referenced this pull request Apr 2, 2024
bastelfreak added a commit to bastelfreak/puppet-keepalived that referenced this pull request Apr 2, 2024
@bastelfreak
Copy link
Member

@cocker-cc I wanted to release this, but I noticed that #327 was already merged so the next release has to be a major one, so I also merged #319

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants