Mark install.pp as private
#338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenyon
force-pushed
the
mark-install-as-private
branch
from
58da19b
to
2232723
Compare
The letsencrypt::install class should be private and shouldn't have its own spec tests. The tests in letsencrypt_install_spec.rb already existed in letsencrypt_spec.rb.
kenyon
force-pushed
the
mark-install-as-private
branch
from
2232723
to
6d18ea9
Compare
bastelfreak
approved these changes
Nov 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
letsencrypt::installclass should be private and shouldn't have its own spec tests. The tests inletsencrypt_install_spec.rbalready existed inletsencrypt_spec.rb.