Clean up fixtures and codebase hardening #58
ci.yml
on: pull_request
Puppet
/
Static validations
18s
Matrix: Puppet / acceptance
Matrix: Puppet / unit
Puppet
/
Test suite
0s
Annotations
10 errors
Puppet / 7 (Ruby 2.7):
spec/classes/init_spec.rb#L161
monit supported operating systems on centos-7-x86_64 parameter functionality when manage_firewall and http are set to valid bool <true> is expected to contain Firewall[2812 allow Monit inbound traffic] with action => "accept", dport => "2812" and proto => "tcp"
Failure/Error:
is_expected.to contain_firewall('2812 allow Monit inbound traffic').with('action' => 'accept',
'dport' => '2812',
'proto' => 'tcp')
Puppet::Error:
no parameter named 'action' (file: /home/runner/work/puppet-monit/puppet-monit/spec/fixtures/modules/monit/manifests/firewall.pp, line: 13) on Firewall[2812 allow Monit inbound traffic] (file: /home/runner/work/puppet-monit/puppet-monit/spec/fixtures/modules/monit/manifests/firewall.pp, line: 13) on node fv-az1487-577.vpy2y30pan5uhaa0ktko4c43jh.ex.internal.cloudapp.net
|
Puppet / 7 (Ruby 2.7):
spec/classes/init_spec.rb#L161
monit supported operating systems on debian-11-x86_64 parameter functionality when manage_firewall and http are set to valid bool <true> is expected to contain Firewall[2812 allow Monit inbound traffic] with action => "accept", dport => "2812" and proto => "tcp"
Failure/Error:
is_expected.to contain_firewall('2812 allow Monit inbound traffic').with('action' => 'accept',
'dport' => '2812',
'proto' => 'tcp')
Puppet::Error:
no parameter named 'action' (file: /home/runner/work/puppet-monit/puppet-monit/spec/fixtures/modules/monit/manifests/firewall.pp, line: 13) on Firewall[2812 allow Monit inbound traffic] (file: /home/runner/work/puppet-monit/puppet-monit/spec/fixtures/modules/monit/manifests/firewall.pp, line: 13) on node fv-az1487-577.vpy2y30pan5uhaa0ktko4c43jh.ex.internal.cloudapp.net
|
Puppet / 7 (Ruby 2.7):
spec/classes/init_spec.rb#L161
monit supported operating systems on centos-8-x86_64 parameter functionality when manage_firewall and http are set to valid bool <true> is expected to contain Firewall[2812 allow Monit inbound traffic] with action => "accept", dport => "2812" and proto => "tcp"
Failure/Error:
is_expected.to contain_firewall('2812 allow Monit inbound traffic').with('action' => 'accept',
'dport' => '2812',
'proto' => 'tcp')
Puppet::Error:
no parameter named 'action' (file: /home/runner/work/puppet-monit/puppet-monit/spec/fixtures/modules/monit/manifests/firewall.pp, line: 13) on Firewall[2812 allow Monit inbound traffic] (file: /home/runner/work/puppet-monit/puppet-monit/spec/fixtures/modules/monit/manifests/firewall.pp, line: 13) on node fv-az1487-577.vpy2y30pan5uhaa0ktko4c43jh.ex.internal.cloudapp.net
|
Puppet / 7 (Ruby 2.7):
spec/classes/init_spec.rb#L161
monit supported operating systems on redhat-7-x86_64 parameter functionality when manage_firewall and http are set to valid bool <true> is expected to contain Firewall[2812 allow Monit inbound traffic] with action => "accept", dport => "2812" and proto => "tcp"
Failure/Error:
is_expected.to contain_firewall('2812 allow Monit inbound traffic').with('action' => 'accept',
'dport' => '2812',
'proto' => 'tcp')
Puppet::Error:
no parameter named 'action' (file: /home/runner/work/puppet-monit/puppet-monit/spec/fixtures/modules/monit/manifests/firewall.pp, line: 13) on Firewall[2812 allow Monit inbound traffic] (file: /home/runner/work/puppet-monit/puppet-monit/spec/fixtures/modules/monit/manifests/firewall.pp, line: 13) on node fv-az1487-577.vpy2y30pan5uhaa0ktko4c43jh.ex.internal.cloudapp.net
|
Puppet / 7 (Ruby 2.7):
spec/classes/init_spec.rb#L161
monit supported operating systems on oraclelinux-8-x86_64 parameter functionality when manage_firewall and http are set to valid bool <true> is expected to contain Firewall[2812 allow Monit inbound traffic] with action => "accept", dport => "2812" and proto => "tcp"
Failure/Error:
is_expected.to contain_firewall('2812 allow Monit inbound traffic').with('action' => 'accept',
'dport' => '2812',
'proto' => 'tcp')
Puppet::Error:
no parameter named 'action' (file: /home/runner/work/puppet-monit/puppet-monit/spec/fixtures/modules/monit/manifests/firewall.pp, line: 13) on Firewall[2812 allow Monit inbound traffic] (file: /home/runner/work/puppet-monit/puppet-monit/spec/fixtures/modules/monit/manifests/firewall.pp, line: 13) on node fv-az1487-577.vpy2y30pan5uhaa0ktko4c43jh.ex.internal.cloudapp.net
|
Puppet / 7 (Ruby 2.7):
spec/classes/init_spec.rb#L161
monit supported operating systems on oraclelinux-9-x86_64 parameter functionality when manage_firewall and http are set to valid bool <true> is expected to contain Firewall[2812 allow Monit inbound traffic] with action => "accept", dport => "2812" and proto => "tcp"
Failure/Error:
is_expected.to contain_firewall('2812 allow Monit inbound traffic').with('action' => 'accept',
'dport' => '2812',
'proto' => 'tcp')
Puppet::Error:
no parameter named 'action' (file: /home/runner/work/puppet-monit/puppet-monit/spec/fixtures/modules/monit/manifests/firewall.pp, line: 13) on Firewall[2812 allow Monit inbound traffic] (file: /home/runner/work/puppet-monit/puppet-monit/spec/fixtures/modules/monit/manifests/firewall.pp, line: 13) on node fv-az1487-577.vpy2y30pan5uhaa0ktko4c43jh.ex.internal.cloudapp.net
|
Puppet / 7 (Ruby 2.7):
spec/classes/init_spec.rb#L161
monit supported operating systems on ubuntu-18.04-x86_64 parameter functionality when manage_firewall and http are set to valid bool <true> is expected to contain Firewall[2812 allow Monit inbound traffic] with action => "accept", dport => "2812" and proto => "tcp"
Failure/Error:
is_expected.to contain_firewall('2812 allow Monit inbound traffic').with('action' => 'accept',
'dport' => '2812',
'proto' => 'tcp')
Puppet::Error:
no parameter named 'action' (file: /home/runner/work/puppet-monit/puppet-monit/spec/fixtures/modules/monit/manifests/firewall.pp, line: 13) on Firewall[2812 allow Monit inbound traffic] (file: /home/runner/work/puppet-monit/puppet-monit/spec/fixtures/modules/monit/manifests/firewall.pp, line: 13) on node fv-az1487-577.vpy2y30pan5uhaa0ktko4c43jh.ex.internal.cloudapp.net
|
Puppet / 7 (Ruby 2.7):
spec/classes/init_spec.rb#L161
monit supported operating systems on scientific-7-x86_64 parameter functionality when manage_firewall and http are set to valid bool <true> is expected to contain Firewall[2812 allow Monit inbound traffic] with action => "accept", dport => "2812" and proto => "tcp"
Failure/Error:
is_expected.to contain_firewall('2812 allow Monit inbound traffic').with('action' => 'accept',
'dport' => '2812',
'proto' => 'tcp')
Puppet::Error:
no parameter named 'action' (file: /home/runner/work/puppet-monit/puppet-monit/spec/fixtures/modules/monit/manifests/firewall.pp, line: 13) on Firewall[2812 allow Monit inbound traffic] (file: /home/runner/work/puppet-monit/puppet-monit/spec/fixtures/modules/monit/manifests/firewall.pp, line: 13) on node fv-az1487-577.vpy2y30pan5uhaa0ktko4c43jh.ex.internal.cloudapp.net
|
Puppet / 7 (Ruby 2.7):
spec/classes/init_spec.rb#L460
monit variable type and content validations with config_file (absolute_path) set to invalid invalid (as String) fails
Failure/Error:
expect do
catalogue
end.to raise_error(Puppet::Error, %r{#{var[:message]}})
expected Puppet::Error with message matching /(expects a String value|is not an absolute path)/, got #<Puppet::PreformattedError: Evaluation Error: Error while evaluating a Resource Statement, Class[Mon...ring (line: 2, column: 1) on node fv-az1487-577.vpy2y30pan5uhaa0ktko4c43jh.ex.internal.cloudapp.net> with backtrace:
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/pops/types/type_mismatch_describer.rb:536:in `validate_parameters'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/pops/types/type_mismatch_describer.rb:499:in `validate_parameters'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/resource/type.rb:290:in `validate_resource_hash'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/resource/type.rb:248:in `set_resource_parameters'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/resource/type.rb:69:in `evaluate_code'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/parser/resource.rb:79:in `block in evaluate'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/util/profiler/around_profiler.rb:58:in `profile'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/util/profiler.rb:51:in `profile'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/parser/resource.rb:71:in `evaluate'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/parser/compiler.rb:259:in `each'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/parser/compiler.rb:259:in `evaluate_classes'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/pops/evaluator/runtime3_resource_support.rb:62:in `block in create_resources'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/pops/evaluator/runtime3_resource_support.rb:37:in `map'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/pops/evaluator/runtime3_resource_support.rb:37:in `create_resources'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/pops/evaluator/runtime3_support.rb:340:in `create_resources'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/pops/evaluator/evaluator_impl.rb:884:in `block in eval_ResourceExpression'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/pops/evaluator/evaluator_impl.rb:881:in `map'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/pops/evaluator/evaluator_impl.rb:881:in `eval_ResourceExpression'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/pops/visitor.rb:94:in `visit_this_1'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/pops/evaluator/evaluator_impl.rb:81:in `evaluate'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/pops/puppet_stack.rb:42:in `stack'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/pops/evaluator/evaluator_impl.rb:756:in `eval_Program'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/pops/visitor.rb:94:in `visit_this_1'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/pops/evaluator/evaluator_impl.rb:81:in `evaluate'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/pops/parser/evaluating_parser.rb:60:in `evaluate'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/parser/ast/pops_bridge.rb:109:in `evaluate'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/parser/ast.rb:30:in `safeevaluate'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/resource/type.rb:80:in `evaluate_code'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/parser/resource.rb:79:in `block in evaluate'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/util/profiler/around_profiler.rb:58:in `profile'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/util/profiler.rb:51:in `profile'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/parser/resourc
|
Puppet / 7 (Ruby 2.7):
spec/classes/init_spec.rb#L460
monit variable type and content validations with config_file (absolute_path) set to invalid 3 (as Integer) fails
Failure/Error:
expect do
catalogue
end.to raise_error(Puppet::Error, %r{#{var[:message]}})
expected Puppet::Error with message matching /(expects a String value|is not an absolute path)/, got #<Puppet::PreformattedError: Evaluation Error: Error while evaluating a Resource Statement, Class[Mon...eger (line: 2, column: 1) on node fv-az1487-577.vpy2y30pan5uhaa0ktko4c43jh.ex.internal.cloudapp.net> with backtrace:
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/pops/types/type_mismatch_describer.rb:536:in `validate_parameters'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/pops/types/type_mismatch_describer.rb:499:in `validate_parameters'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/resource/type.rb:290:in `validate_resource_hash'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/resource/type.rb:248:in `set_resource_parameters'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/resource/type.rb:69:in `evaluate_code'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/parser/resource.rb:79:in `block in evaluate'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/util/profiler/around_profiler.rb:58:in `profile'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/util/profiler.rb:51:in `profile'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/parser/resource.rb:71:in `evaluate'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/parser/compiler.rb:259:in `each'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/parser/compiler.rb:259:in `evaluate_classes'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/pops/evaluator/runtime3_resource_support.rb:62:in `block in create_resources'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/pops/evaluator/runtime3_resource_support.rb:37:in `map'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/pops/evaluator/runtime3_resource_support.rb:37:in `create_resources'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/pops/evaluator/runtime3_support.rb:340:in `create_resources'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/pops/evaluator/evaluator_impl.rb:884:in `block in eval_ResourceExpression'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/pops/evaluator/evaluator_impl.rb:881:in `map'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/pops/evaluator/evaluator_impl.rb:881:in `eval_ResourceExpression'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/pops/visitor.rb:94:in `visit_this_1'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/pops/evaluator/evaluator_impl.rb:81:in `evaluate'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/pops/puppet_stack.rb:42:in `stack'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/pops/evaluator/evaluator_impl.rb:756:in `eval_Program'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/pops/visitor.rb:94:in `visit_this_1'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/pops/evaluator/evaluator_impl.rb:81:in `evaluate'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/pops/parser/evaluating_parser.rb:60:in `evaluate'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/parser/ast/pops_bridge.rb:109:in `evaluate'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/parser/ast.rb:30:in `safeevaluate'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/resource/type.rb:80:in `evaluate_code'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/parser/resource.rb:79:in `block in evaluate'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/util/profiler/around_profiler.rb:58:in `profile'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/util/profiler.rb:51:in `profile'
# ./vendor/bundle/ruby/2.7.0/gems/puppet-7.28.0/lib/puppet/parser/resource.rb:
|