Add raw_ssl_append and raw_ssl_prepend #1361
Conversation
nginx::resource::server is a typeThe enclosing module is declared in 11 of 578 indexed public Puppetfiles. Breaking changes to this file WILL impact these modules (exact match):
Breaking changes to this file MAY impact these modules (near match): These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report. Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only. |
| @@ -222,7 +226,8 @@ | |||
| String $fastcgi_params = "${nginx::conf_dir}/fastcgi.conf", | |||
| Optional[String] $fastcgi_script = undef, | |||
| Optional[String] $uwsgi = undef, | |||
| String $uwsgi_params = "${nginx::config::conf_dir}/uwsgi_params", | |||
| String $uwsgi_params = "${nginx::config::conf_dir} | |||
| /uwsgi_params", | |||
There was a problem hiding this comment.
Did you add a newline here? Was this intentional?
| @@ -251,6 +256,8 @@ | |||
| $client_max_body_size = undef, | |||
| Optional[Variant[Array[String], String]] $raw_prepend = undef, | |||
| Optional[Variant[Array[String], String]] $raw_append = undef, | |||
| Optional[Variant[Array[String], String]] $raw_ssl_prepend = undef, | |||
There was a problem hiding this comment.
Can you enforce the minimal string length? I think empty strings don't make sense here:
| Optional[Variant[Array[String], String]] $raw_ssl_prepend = undef, | |
| Optional[Variant[Array[String[1]], String[1]]] $raw_ssl_prepend = undef, |
| @@ -251,6 +256,8 @@ | |||
| $client_max_body_size = undef, | |||
| Optional[Variant[Array[String], String]] $raw_prepend = undef, | |||
| Optional[Variant[Array[String], String]] $raw_append = undef, | |||
| Optional[Variant[Array[String], String]] $raw_ssl_prepend = undef, | |||
| Optional[Variant[Array[String], String]] $raw_ssl_append = undef, | |||
There was a problem hiding this comment.
| Optional[Variant[Array[String], String]] $raw_ssl_append = undef, | |
| Optional[Variant[Array[String[1]], String[1]]] $raw_ssl_append = undef, |
|
@supa-creation thanks for the PR. Can you please take a look at the used email address in your commit? It isn't associated with your github account. |
|
Dear @supa-creation, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
Pull Request (PR) description
This Pull Request (PR) fixes the following issues