Skip to content

fix: use install_method param in exporters #940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

anantha1999
Copy link

Pull Request (PR) description

The PR fixes the issue by using install_method class param here -

install_method => 'url',

This Pull Request (PR) fixes the following issues

Fixes #939

@TheMeier
Copy link
Contributor

can you also update the other ones too please.

https://github.com/search?q=repo%3Avoxpupuli%2Fpuppet-prometheus+%22+%3D%3E+%27url%27%2C%22++path%3A%2F%5Emanifests%5C%2F%2F&type=code

@anantha1999
Copy link
Author

anantha1999 commented Jul 14, 2025

@TheMeier process_exporter is correct -

install_method => $install_method,

Have made changes in systemd and jmx. However jmx didn't have the install_method param, is this by design (because CI is failing after the change)? if it is I can revert my last commit

@anantha1999 anantha1999 changed the title fix: use install_method param in systemd_exporter fix: use install_method param in exporters Jul 14, 2025
@anantha1999
Copy link
Author

Fixed CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

systemd_exporter using hardcoded value url for install-method
2 participants