splunk_metadata - is_global? -> global?#312
Open
ptgeorge wants to merge 1 commit intovoxpupuli:masterfrom
Open
splunk_metadata - is_global? -> global?#312ptgeorge wants to merge 1 commit intovoxpupuli:masterfrom
ptgeorge wants to merge 1 commit intovoxpupuli:masterfrom
Conversation
The function "is_global?" should be named "global?". Reference: https://github.com/puppetlabs/puppetlabs-inifile/blob/main/lib/puppet/util/ini_file/section.rb#L28-L30
smortex
approved these changes
Jul 21, 2021
Member
smortex
left a comment
smortex
left a comment
There was a problem hiding this comment.
The function was renamed in puppetlabs/puppetlabs-inifile@c6823f9 to make Rubocop happier.
Member
|
D'oh! Puppet 5 🙃 The build failure is expected and not transient. I opened #313 to address this specific issue. |
Member
|
Hello @ptgeorge can you rabase with our master branch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
The function "is_global?" should be named "global?".
Reference: https://github.com/puppetlabs/puppetlabs-inifile/blob/main/lib/puppet/util/ini_file/section.rb#L28-L30
This Pull Request (PR) fixes the following issues
n/a