-
-
Notifications
You must be signed in to change notification settings - Fork 242
Support nested facts in inventory view #1291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1291 +/- ##
==========================================
+ Coverage 76.92% 77.08% +0.15%
==========================================
Files 20 20
Lines 1309 1322 +13
==========================================
+ Hits 1007 1019 +12
- Misses 302 303 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay, I added in-line note for something I think should not be there. In the future, please try to separate actual changes from style changes to make review easier, Thanks!
c0620b2
to
9251813
Compare
Yes, agree, sorry about that! 🫶 I can remove the style changes ofc. Do you want me to? |
Change INVENTORY_FACTS to use supported facts using dot notation
9251813
to
6e670b6
Compare
I went ahead and reverted the style changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Change INVENTORY_FACTS to use supported facts using dot notation
Fixes #874