Skip to content

Support nested facts in inventory view #1291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nikolaik
Copy link
Contributor

@nikolaik nikolaik commented Jun 4, 2025

Change INVENTORY_FACTS to use supported facts using dot notation

Fixes #874

Copy link

codecov bot commented Jun 4, 2025

Codecov Report

Attention: Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.08%. Comparing base (6b6e8df) to head (6e670b6).

Files with missing lines Patch % Lines
puppetboard/utils.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1291      +/-   ##
==========================================
+ Coverage   76.92%   77.08%   +0.15%     
==========================================
  Files          20       20              
  Lines        1309     1322      +13     
==========================================
+ Hits         1007     1019      +12     
- Misses        302      303       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay, I added in-line note for something I think should not be there. In the future, please try to separate actual changes from style changes to make review easier, Thanks!

@nikolaik nikolaik force-pushed the nikolaik/dot-lookup branch from c0620b2 to 9251813 Compare June 4, 2025 18:38
@nikolaik
Copy link
Contributor Author

nikolaik commented Jun 4, 2025

Looks okay, I added in-line note for something I think should not be there. In the future, please try to separate actual changes from style changes to make review easier, Thanks!

Yes, agree, sorry about that! 🫶 I can remove the style changes ofc. Do you want me to?

Change INVENTORY_FACTS to use supported facts using dot notation
@nikolaik nikolaik force-pushed the nikolaik/dot-lookup branch from 9251813 to 6e670b6 Compare June 4, 2025 19:37
@nikolaik
Copy link
Contributor Author

nikolaik commented Jun 4, 2025

Looks okay, I added in-line note for something I think should not be there. In the future, please try to separate actual changes from style changes to make review easier, Thanks!

Yes, agree, sorry about that! 🫶 I can remove the style changes ofc. Do you want me to?

I went ahead and reverted the style changes

Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@smortex smortex changed the title feat: Support nested facts in inventory view Support nested facts in inventory view Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inventory tab feature legacy facts
2 participants