Don't update module version to -rc after release tag #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added it for discussion for the last monthly sync but we had no time to reach this topic: |
kenyon
changed the title
|
@smortex nice, lets continue the discussion there. |
h-haaks
reviewed
Jul 18, 2025
| Rake::Task['module:bump:full'].invoke | ||
|
|
||
| # push it out, and let GitHub Actions do the release: | ||
| g.commit_modulefile!(v_new) |
There was a problem hiding this comment.
No need for the test at line 58 if this is removed :)
There was a problem hiding this comment.
I'd prefer to keep the test in for modules which have been updated to RC versions. Over time the need may disappear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up for discussion and not yet tested it. @ekohl and I discussed it during voxconf. If it works, I would like to discuss the change in the community and add more explanation.