Feature: Add ability to have custom mappings of repository name to a prefix #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhollinger
requested changes
Jul 7, 2025
lib/helpers/prefix.go
Outdated
Comment on lines
23
to
30
| func (h *Helper) GetPrefixFromMapping(mapping map[string]string, repoName string) (string, error) { | ||
| prefix, ok := mapping[repoName] | ||
| if ok { | ||
| return prefix, nil | ||
| } else { | ||
| return "", fmt.Errorf("Prefix not found in mapping for repo '%s'", repoName) | ||
| } | ||
| } |
There was a problem hiding this comment.
Formatting issues. Use tabs instead of spaces here
lib/helpers/prefix.go
Outdated
| @@ -1,6 +1,7 @@ | |||
| package helpers | |||
|
|
|||
| import ( | |||
| "fmt" | |||
lib/helpers/prefix_test.go
Outdated
Comment on lines
32
to
52
| func Test_GetPrefixFromMapping(t *testing.T) { | ||
| h := Helper{} | ||
| mapping := map[string]string{ | ||
| "testrepo": "testprefix", | ||
| "otherrepo": "", | ||
| } | ||
|
|
||
| prefix, err := h.GetPrefixFromMapping(mapping, "testrepo") | ||
| assert.NilError(t, err) | ||
| assert.Equal(t, "testprefix", prefix) | ||
|
|
||
| prefix, err = h.GetPrefixFromMapping(mapping, "otherrepo") | ||
| assert.NilError(t, err) | ||
| assert.Equal(t, "", prefix) | ||
|
|
||
| // Test with a repo not in the mapping | ||
| prefix, err = h.GetPrefixFromMapping(mapping, "nonexistentrepo") | ||
| assert.Error(t, err, "Prefix not found in mapping for repo 'nonexistentrepo'") | ||
| assert.Equal(t, "", prefix) | ||
|
|
||
| } |
There was a problem hiding this comment.
formatting. Tabs instead of spaces.
Fixed the formatting of the code and removed a shadow declaration of the `err` variable
dhollinger
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
webhook-goin a large enterprise setup we have lots of Puppet control repositories all pointing to the same r10k setup. As part of this we want to prefix environments with short keys to differentiate them.This PR adds an extra config option that maps a repostiory name to a prefix. It requires setting the prefix to "mapping".