-
-
Notifications
You must be signed in to change notification settings - Fork 287
Improve locale framework for improved modularity and easier maintenance #717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Improve locale framework for improved modularity and easier maintenance #717
Conversation
|
This PR is a draft, a placeholder. No work has begun, and the current commit is from a different PR. The PR will likely have to also go into the https://github.com/vrtmrz/livesync-commonlib repo, as that's where translations are kept (as far as I can tell). |
… some areas instead of "magical values".
…atures/SettingDialogue to src/modules/features/SettingsDialog
…ed) to PageGeneral. Improve wording on "Welcome" and "Select Setup Method" dialogs.
…ity to more options/actions in PageMaintenance.ts. Removed already ported options/actions from PaneHatch.ts and PaneMaintenance.ts.
|
Hi! Thank you for your brilliant works! And, sorry for the delayed comment. Now, I realise this request is rather awkward at such a time, but could you please provide the language resources in YAML? Currently, [lang].json are generated from [lang].yaml by The issue is that it is indeed very difficult to include text containing symbols or line breaks in JSON, and merging is also challenging... I apologise for making this request without having seen the content yet. |
…d to PageGeneral.ts).
…e some UI controls to render above section titles. Updated new tabs to use updated translations. Updated Sync page to have some settings.
DRAFT
The focus of this PR will be migrating from a single JSON file per language to multiple files per language.
Rather than having a single JSON file hundreds of lines long, this PR will work on migrating to multiple JSON files. This change will improve readability, sorting messages by the settings page they are found in. As a result, this will also improve maintainability.
Current
common/
├─ messagesJson/
│ ├─ de.json
│ ├─ en.json
│ ├─ es.json
│ ├─ ja.json
│ ├─ ko.json
│ ├─ ru.json
│ ├─ zh-tw.json
│ ├─ zh.json
Proposed
common/
├─ locales/
│ ├─ template/
│ │ ├─ actions.json
│ │ ├─ page_getting_started.json
│ │ ├─ page_general.json
│ │ ├─ page_remote.json
│ │ ├─ page_sync.json
│ │ ├─ page_maintenance.json
│ │ ├─ page_about.json
│ ├─ en/
│ ├─ es/
│ ├─ [...]/