Skip to content

Conversation

@chriscross12324
Copy link

DRAFT
The focus of this PR will be migrating from a single JSON file per language to multiple files per language.

Rather than having a single JSON file hundreds of lines long, this PR will work on migrating to multiple JSON files. This change will improve readability, sorting messages by the settings page they are found in. As a result, this will also improve maintainability.

Current
common/
├─ messagesJson/
│ ├─ de.json
│ ├─ en.json
│ ├─ es.json
│ ├─ ja.json
│ ├─ ko.json
│ ├─ ru.json
│ ├─ zh-tw.json
│ ├─ zh.json

Proposed
common/
├─ locales/
│ ├─ template/
│ │ ├─ actions.json
│ │ ├─ page_getting_started.json
│ │ ├─ page_general.json
│ │ ├─ page_remote.json
│ │ ├─ page_sync.json
│ │ ├─ page_maintenance.json
│ │ ├─ page_about.json
│ ├─ en/
│ ├─ es/
│ ├─ [...]/

@chriscross12324
Copy link
Author

This PR is a draft, a placeholder. No work has begun, and the current commit is from a different PR. The PR will likely have to also go into the https://github.com/vrtmrz/livesync-commonlib repo, as that's where translations are kept (as far as I can tell).

…ed) to PageGeneral. Improve wording on "Welcome" and "Select Setup Method" dialogs.
…ity to more options/actions in PageMaintenance.ts. Removed already ported options/actions from PaneHatch.ts and PaneMaintenance.ts.
@vrtmrz
Copy link
Owner

vrtmrz commented Oct 5, 2025

Hi! Thank you for your brilliant works! And, sorry for the delayed comment.
I had not seen it as it was a draft. I am currently undertaking some significant modifications (please take care of the structural changes).

Now, I realise this request is rather awkward at such a time, but could you please provide the language resources in YAML? Currently, [lang].json are generated from [lang].yaml by yaml2json.ts.
Of course, I am very much in favour of splitting them up.

The issue is that it is indeed very difficult to include text containing symbols or line breaks in JSON, and merging is also challenging...

I apologise for making this request without having seen the content yet.
I expect we will be able to get a new beta shortly, so we can test with that beta soon.

Chris Coulthard added 3 commits October 10, 2025 23:13
…e some UI controls to render above section titles. Updated new tabs to use updated translations. Updated Sync page to have some settings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants